Merge lp://qastaging/~alan-griffiths/mir/revert-3423 into lp://qastaging/mir

PASSED: Continuous integration, rev:3426
https://mir-jenkins.ubuntu.com/job/mir-ci/688/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/640
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/677
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/669
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/669
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/650
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/650/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/650
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/650/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/650
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/650/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/650
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/650/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/650
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/650/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/688/rebuild

I don't think impolite clients belong in "examples".

Perhaps we can have this under <mir>/tests/impolite-clients

> I don't think impolite clients belong in "examples".

I agree we should have "good" examples, the question is whether that trumps having a test that real servers handle bad clients.

Reverting is a quick way to restore the test.

> Perhaps we can have this under <mir>/tests/impolite-clients

I want to add some more "smoke" tests, but fixing that takes a little longer. E.g. we don't seem to be running mir_stress anywhere.

Regardless of whether people think an example is good or bad, polite or impolite, I think we do need more standalone examples. And more examples that don't all use the same codebase, but rather can be viewed in a single source file.

So yeah it's less clean but more useful as an 'example' this way.

Withdrawing the MP.

My principle motivation was to restore the test, but we now "smoke test" the same code in mir_test_client_impolite_shutdown (e.g.https://mir-jenkins.ubuntu.com/job/device-runtests-mir/device_type=krillin/323/console).