Code review comment for lp://qastaging/~allenap/maas/rabbit-resource

Revision history for this message
Raphaël Badin (rvb) wrote :

Looks good!

The only thing that I don't like about this is that it has slowed down the execution of the test suite (10s on my machine [this branch] vs. 0.4s [trunk]) but I guess there is not much we can do about it :(

[0]

8 - ${buildout:directory}/src/
9 - ${buildout:directory}/src/maas/
10 - ${buildout:directory}/src/maasserver/
11 + ${buildout:directory}/src

You just stole my next drive-by fix! :)

[1]

152 === renamed directory 'src/maas/testing' => 'src/maastesting'

I like that! Much better to have an app (maasserver) depend on another app rather that on some resource located in a project!

review: Approve

« Back to merge proposal