Code review comment for lp://qastaging/~andersk/unity-lens-applications/lp778202

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I'm request Jason's view on bamf, but I think you just trigger by that the fallback of the bamf integration, which is really awesome (we didn't see for a while in both maverick and natty that for a long period of time, we were in the fallback mode as Jason has done a perfect job on that), but with trickier application like java, python and such, this becomes untrue.

I really prefer the "GLib.Shell.parse_arg" path if you can implement that than the hack of sh -c. Seems more robust and clean code-wise.

For others cases like ‘sleep 5; do something else’ I think that "run in a terminal" checkbox is a better way to fix that problem as it's clearly explicit. I'm not even sure that gnome-panel alt + F2 supported that in fact.

I'm adding Jason to this review so that he can help on the bamf side.

Thanks for your further investigation :)

« Back to merge proposal