Merge lp://qastaging/~andreagrandi/unity-2d/trash-nautilus-setting into lp://qastaging/unity-2d/3.0

Nice work Andrea.
A few comments:
- the strings need to be made translatable; see http://doc.qt.nokia.com/4.7-snapshot/internationalization.html#step-by-step for more information
- the dialog box should not have a title (right now it's 'unity-2d-launcher')
- the dialog box should be the same size as nautilus' (a bit bigger than with this patch)

Another issue: when the dialog box is up, an icon appears in the launcher which should not.

> Nice work Andrea.
> A few comments:
> - the strings need to be made translatable; see
> http://doc.qt.nokia.com/4.7-snapshot/internationalization.html#step-by-step
> for more information

the Qt way is using tr("....") but I've seen that you're using another macro: u2dTr("...."), do I have to use this one?

> - the dialog box should not have a title (right now it's 'unity-2d-launcher')

I've set it to "" with this line: msgBox.setWindowTitle(""); but the string "unity-2d-launcher" is shown anyway. Any idea?

> - the dialog box should be the same size as nautilus' (a bit bigger than with
> this patch)

you mean the message box displayed by the Gnome Trash Applet or the message box displayed by Unity? They're a bit different: the Gnome one has a button named in a different way and the text displayed is a bit different: "If you choose to empty the trash, all items in it will be permanently lost. Please note that you can also delete them separately.". Which one do I have to use?

> Another issue: when the dialog box is up, an icon appears in the launcher which should not.

this is probably a behaviour of QtMessageBox... I can try to see which properties I can modify but I'm not sure it will be possible. Any idea?

Why not using nautilus3 dbus interface?

> > Nice work Andrea.
> > A few comments:
> > - the strings need to be made translatable; see
> > http://doc.qt.nokia.com/4.7-snapshot/internationalization.html#step-by-step
> > for more information
>
> the Qt way is using tr("....") but I've seen that you're using another macro:
> u2dTr("...."), do I have to use this one?

Yes, you should use the u2dTr one.

>
> > - the dialog box should not have a title (right now it's 'unity-2d-
> launcher')
>
> I've set it to "" with this line: msgBox.setWindowTitle(""); but the string
> "unity-2d-launcher" is shown anyway. Any idea?

Unfortunately no, not at the moment. I guess it will take some digging around :/

>
> > - the dialog box should be the same size as nautilus' (a bit bigger than
> with
> > this patch)
>
> you mean the message box displayed by the Gnome Trash Applet or the message
> box displayed by Unity? They're a bit different: the Gnome one has a button
> named in a different way and the text displayed is a bit different: "If you
> choose to empty the trash, all items in it will be permanently lost. Please
> note that you can also delete them separately.". Which one do I have to use?
>

Let's use nautilus'
Unity should be modified to follow that I believe.

> > Another issue: when the dialog box is up, an icon appears in the launcher
> which should not.
>
> this is probably a behaviour of QtMessageBox... I can try to see which
> properties I can modify but I'm not sure it will be possible. Any idea?

Hmmm, I am not sure, I would suggest trying various options of:

QWidget::setWindowFlags
and
QWidget::setAttribute

> Why not using nautilus3 dbus interface?

That would be the best!
Do you know what it looks like? What methods are available?

Let's make a quick resume of the available options.

1) I can keep trying tuning these: QWidget::setWindowFlags and QWidget::setAttribute
but I've already tried and until now I wasn't able to fix it in this way.

2) We could try the method suggested by Andrea Azzarone, but keep in mind that it only works with Ubuntu Oneiric, it won'r work on Natty. So we have to choose: do we want this bug fixed only in Oneiric or in Natty too?

My suggestion: let's use the QtMessageBox for Natty, doing our best even if it's not exactly the same and let's use the dbus method for Oneiric.

Do we have separate trunks for Natty and Oneiric of Unity-2d?

> Let's make a quick resume of the available options.
>
> 1) I can keep trying tuning these: QWidget::setWindowFlags and
> QWidget::setAttribute
> but I've already tried and until now I wasn't able to fix it in this way.
>
> 2) We could try the method suggested by Andrea Azzarone, but keep in mind that
> it only works with Ubuntu Oneiric, it won'r work on Natty. So we have to
> choose: do we want this bug fixed only in Oneiric or in Natty too?
>

This is the way to go. It's acceptable to not have this bug fixed on Natty.

> My suggestion: let's use the QtMessageBox for Natty, doing our best even if
> it's not exactly the same and let's use the dbus method for Oneiric.
>

Hmmm, I am not so keen on merging code with known bugs when we have the choice therefore I would only merge the complete and proper fix in Oneiric.

> Do we have separate trunks for Natty and Oneiric of Unity-2d?

Yes.
Natty: lp:unity-2d/3.0
Oneiric: lp:unity-2d

Ok so I'll use the dbus method and will fix this for Oneiric. I'll talk with Andrea Azzarone to understand how it works exactly, since he has already used that method before.

I've fixed it and I've done the merge request using another trunk since the new one is based on Unity-2d 4.0 and not 3.0 like the old one. The new merge request is here: https://code.launchpad.net/~andreagrandi/unity-2d/trash-nautilus-setting-oneiric/+merge/73960