Code review comment for lp://qastaging/~andreagrandi/unity-2d/trash-nautilus-setting

> > Nice work Andrea.
> > A few comments:
> > - the strings need to be made translatable; see
> > http://doc.qt.nokia.com/4.7-snapshot/internationalization.html#step-by-step
> > for more information
>
> the Qt way is using tr("....") but I've seen that you're using another macro:
> u2dTr("...."), do I have to use this one?

Yes, you should use the u2dTr one.

>
> > - the dialog box should not have a title (right now it's 'unity-2d-
> launcher')
>
> I've set it to "" with this line: msgBox.setWindowTitle(""); but the string
> "unity-2d-launcher" is shown anyway. Any idea?

Unfortunately no, not at the moment. I guess it will take some digging around :/

>
> > - the dialog box should be the same size as nautilus' (a bit bigger than
> with
> > this patch)
>
> you mean the message box displayed by the Gnome Trash Applet or the message
> box displayed by Unity? They're a bit different: the Gnome one has a button
> named in a different way and the text displayed is a bit different: "If you
> choose to empty the trash, all items in it will be permanently lost. Please
> note that you can also delete them separately.". Which one do I have to use?
>

Let's use nautilus'
Unity should be modified to follow that I believe.

> > Another issue: when the dialog box is up, an icon appears in the launcher
> which should not.
>
> this is probably a behaviour of QtMessageBox... I can try to see which
> properties I can modify but I'm not sure it will be possible. Any idea?

Hmmm, I am not sure, I would suggest trying various options of:

QWidget::setWindowFlags
and
QWidget::setAttribute