Merge lp://qastaging/~anotherjesse/nova/fix-nova-manage-floating-list into lp://qastaging/~hudson-openstack/nova/trunk

If the host field isn't used anymore can we get rid of init_host_floating_ips in the FloatingIP mixin and the floating_ip_get_all_by_host in the dbapi?

Here's one of the rows that comes out of 'nova fixed list' on my nova-compute node 'nova1' using this branch:

network IP address MAC address hostname host
192.168.0.0/25 192.168.0.0 02:16:3e:10:12:37 my_server nova1

The 'host' and 'hostname' labels are synonymous to me. Maybe you can change the hostname label to instance_name? And some capitalization would be nice :)

something isn't quite right here. A floating IP's host refers to the network node doing the NAT. This should be getting set. I'm looking into it...

OK i see what's happening. Prior to multi-nic floating IPs were owned by a particular network host. I embraced the concept of floating by not assigning floating IPs to a certain host, but instead referring to the floating IP's fixed IP's network's host whenever it was necessary. This way floating IPs are never tied to a certain host.

I can see two ways to move forward from here. We can set the host at the time the floating IP is associated with a fixed IP in order to refer to it, or we can remove the host column and get to the host as described above. floatin_ip_get_by_host() actually still makes sense because if a floating IP is associated there will be a network host (or a compute host in vish's ha-net, same difference) performing NAT for this address. We may want to find this information for cases where a network host goes down or needs to be replaced.

I guess what I'd like to see are examples of the current uselessness of the command as well as an example of a useful output.

Trey: I talk about the report issues in the bug:

result:

* output doesn't show who they are allocated to (the project)
* output shows "host" (which is None) since that field doesn't seem to be used any more
* output shows instance hostname, which is unusable since there is no uniqueness constraint

expected:

* show the project (if any) the floating ip is allocated to
* show the instance name instead of hostname if associated with an instance
* don't show host since it isn't used