Merge lp://qastaging/~anso/nova/imgcopy into lp://qastaging/~hudson-openstack/nova/trunk

Proposed by Todd Willey
Status: Work in progress
Proposed branch: lp://qastaging/~anso/nova/imgcopy
Merge into: lp://qastaging/~hudson-openstack/nova/trunk
Diff against target: 172 lines (+71/-22)
4 files modified
nova/image/s3.py (+5/-2)
nova/objectstore/image.py (+18/-20)
nova/tests/objectstore_unittest.py (+4/-0)
tools/imgcopy.sh (+44/-0)
To merge this branch: bzr merge lp://qastaging/~anso/nova/imgcopy
Reviewer Review Type Date Requested Status
Thierry Carrez (community) Abstain
Soren Hansen (community) Needs Resubmitting
Trey Morris (community) Approve
Devin Carlen (community) Approve
Review via email: mp+36522@code.qastaging.launchpad.net

Commit message

Replicate images across regions by putting tools/imgcopy.sh in cron on each end.

Description of the change

Replicate images across regions by putting tools/imgcopy.sh in cron on each end.

To post a comment you must log in.
Revision history for this message
Jesse Andrews (anotherjesse) wrote :

This allows a simplistic version of multi-region. For use until glance/swift become the image store.

Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve
lp://qastaging/~anso/nova/imgcopy updated
288. By Todd Willey

Merge to more recent trunk.

289. By Todd Willey

Don't list or lauch deregistered images.

Revision history for this message
Soren Hansen (soren) wrote :

This looks a bit odd to me, to be honest. We're only syncing images, not the entire objectstore content (right?), so the references in the json (to the original S3 location) will be invalid.

This really looks like something that should happen by consuming the existing API's, not by hacking things on the backend. So, it could do a DescribeImages, find the original location of the registered images from that, copy those over to the other region's object store and register them there. People used to EC2 won't expect images to have the same AMI's across regions, so this is something consumers of the services should be prepared to handle anyway.

Revision history for this message
Trey Morris (tr3buchet) wrote :

I don't see what's wrong with having a hack in place allowing multi-region until the image store is in place.

Revision history for this message
Trey Morris (tr3buchet) :
review: Approve
Revision history for this message
Thierry Carrez (ttx) wrote :

This one has been around for a while, are we lacking consensus to get this merged ?

Revision history for this message
Thierry Carrez (ttx) wrote :

Do we still want to merge this ? If yes, since there is no blueprint around this, please provide some insight on why we need this for Bexar, and a quick analysis of the (lack of) regression risk.

review: Needs Information (ffe)
Revision history for this message
Thierry Carrez (ttx) wrote :

past-FFe, do not merge this in Bexar. To reconsider for Cactus.

review: Disapprove (ffe)
lp://qastaging/~anso/nova/imgcopy updated
290. By Todd Willey

Deal with old lockfiles (from crashes, etc).

Revision history for this message
Soren Hansen (soren) wrote :

Bexar GammaFreeze has kicked in, deferred to Cactus. Setting to "Work in Progress" to clear the review queue. Feel free to set back to "Needs Review" once Cactus opens up (of if this issue gets promoted to a release critical one).

review: Needs Resubmitting
Revision history for this message
Thierry Carrez (ttx) :
review: Abstain

Unmerged revisions

290. By Todd Willey

Deal with old lockfiles (from crashes, etc).

289. By Todd Willey

Don't list or lauch deregistered images.

288. By Todd Willey

Merge to more recent trunk.

287. By Todd Willey

Finalize flags for rsync and order of operations.

286. By Todd Willey

Add run-once locking for imgcopy tool.

285. By Todd Willey

Skeletion of a script that can be run from cron to copy images between regions.

284. By Todd Willey

Don't delete image files on a deregister. This is to support a tool that will
replicate images between regions. We have to push in both directions, so as
long as the image existed in one region it would always get pushed back.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.