On Sat, 2013-05-18 at 02:58 +0000, Lars Uebernickel wrote:
> This is for images that are not in the theme (for example user avatars
> or favicons).
>
> This patch basically replaces g_icon_from_string() with
> g_icon_deserialize(), a new function in Gio which is a bit saner: it
> doesn't require GdkPixbuf on the other side of the bus. This will be
> handy for Unity 8, because Qt already has png decoding functionality,
> it should really not have to link against gdkpixbuf.
But we don't allow icons that aren't in the theme on the panel. So I
don't see why we need it at all in libindicator. Sure it might be
needed for messaging menu and other things that use avatars, but
libindicator doesn't need that feature.
On Sat, 2013-05-18 at 02:58 +0000, Lars Uebernickel wrote:
> This is for images that are not in the theme (for example user avatars from_string( ) with deserialize( ), a new function in Gio which is a bit saner: it
> or favicons).
>
> This patch basically replaces g_icon_
> g_icon_
> doesn't require GdkPixbuf on the other side of the bus. This will be
> handy for Unity 8, because Qt already has png decoding functionality,
> it should really not have to link against gdkpixbuf.
But we don't allow icons that aren't in the theme on the panel. So I
don't see why we need it at all in libindicator. Sure it might be
needed for messaging menu and other things that use avatars, but
libindicator doesn't need that feature.