Code review comment for lp://qastaging/~attente/libindicator/gicon-serialization

Revision history for this message
Lars Karlitski (larsu) wrote :

> But we don't allow icons that aren't in the theme on the panel. So I
> don't see why we need it at all in libindicator. Sure it might be
> needed for messaging menu and other things that use avatars, but
> libindicator doesn't need that feature.

Yes it does, IndicatorNg turns the indicator menu models into GtkMenus, and needs to convert icons into GtkImages in the process.

We probaby don't need it for indicator-image-helper (except maybe for the case Will is describing), but I think we should keep it for completeness sake. It would be confusing if we allowed custom icons in the menus but not in the panel itself.

« Back to merge proposal