Code review comment for lp://qastaging/~attente/libindicator/gicon-serialization

On Sat, 2013-05-18 at 05:24 +0000, William Hua wrote:

> The new keyboard indicator will probably need this support (see:
> https:��wiki.ubuntu.com�LanguageAndText#Icon). But yes, you're correct
> that the indicator service will need to infer the theming information
> from the panel service to render the icons properly. I'm not sure if
> there's a better way than exposing that information through a DBus
> method though.

Hmm, I don't see where it needs that. It has instructions for the
visual designers on the data in the icons, but I still don't see why
they shouldn't be in the theme. For instance, the background color
would be different depending on the theme. Computer generated icons are
never a good experience.

I think that what would make sense, as a temporary solution, is to have
indicator-keyboard generate fallback icons in the hicolor theme as part
of it's build. That way it can know they exist, but then allow a proper
theme to be generated as well.