Code review comment for lp://qastaging/~azzar1/unity/fix-850984

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Overall looks very good to me.
>
> 133 + std::list<AbstractPlacesGroup*> groups;
> 134 +
> 135 + std::transform(children.begin(), children.end(),
> std::back_inserter(groups),
> 136 + [](Area* obj) -> AbstractPlacesGroup*
> 137 + {
> 138 + return static_cast<AbstractPlacesGroup*>(obj);
> 139 + });
>
> I this really much more optimized, than using a normal loop? I mean, it's a
> nice C++ code, but it could look more cryptic than it really is :)

Not sure, how do you prefer?

« Back to merge proposal