Merge lp://qastaging/~azzar1/unity/fix-dodge-active-window into lp://qastaging/unity

Proposed by Andrea Azzarone
Status: Merged
Approved by: Alex Launi
Approved revision: no longer in the source branch.
Merged at revision: 1189
Proposed branch: lp://qastaging/~azzar1/unity/fix-dodge-active-window
Merge into: lp://qastaging/unity
Diff against target: 26 lines (+8/-1)
1 file modified
src/Launcher.cpp (+8/-1)
To merge this branch: bzr merge lp://qastaging/~azzar1/unity/fix-dodge-active-window
Reviewer Review Type Date Requested Status
Alex Launi (community) Approve
Review via email: mp+61912@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Launi (alexlauni) wrote :

I don't like this as a general solution, I think it's very ugly to have stuff like
...
int type_dialogs = CompWindowTypeDialogMask | CompWindowTypeModalDialogMask
                     | CompWindowTypeUtilMask;

if (window && (window->type () & type_dialogs))
...

all over the place, but this is a general compiz slop problem, and is fine for now. I'm going to add a //FIXME to add api to compiz and eventually replace this with some kind of window->IsModalDialog () call. This will get into the SRU but I'd like to see this fixed properly for O.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.