Code review comment for lp://qastaging/~azzar1/unity/fix-dodge-active-window

Revision history for this message
Alex Launi (alexlauni) wrote :

I don't like this as a general solution, I think it's very ugly to have stuff like
...
int type_dialogs = CompWindowTypeDialogMask | CompWindowTypeModalDialogMask
                     | CompWindowTypeUtilMask;

if (window && (window->type () & type_dialogs))
...

all over the place, but this is a general compiz slop problem, and is fine for now. I'm going to add a //FIXME to add api to compiz and eventually replace this with some kind of window->IsModalDialog () call. This will get into the SRU but I'd like to see this fixed properly for O.

review: Approve

« Back to merge proposal