Code review comment for lp://qastaging/~bac/juju-quickstart/1309678

Revision history for this message
Brad Crittenden (bac) wrote :

*** Submitted:

Make control-bucket optional.

The existing function get_admin_secret is made generic and the name is
changed
to get_value_from_jenv. It now takes a keyname to be fetched from the
generated file.

For both ec2 and openstack the control-bucket field has been made
optional
with respect to the environments.yaml file.

QA:

1) Create an ec2 environment with no control-bucket.
2) Bootstrap that environment. Ensure a control-bucket is in the .jenv
file.
3) Run quickstart and see that it uses the existing environment and does
not
raise an error.

R=frankban
CC=
https://codereview.appspot.com/90060043

https://codereview.appspot.com/90060043/

« Back to merge proposal