Code review comment for lp://qastaging/~bac/juju-quickstart/packaging-tweaks

Revision history for this message
Brad Crittenden (bac) wrote :

Thanks for the review. One question in-line.

https://codereview.appspot.com/103310043/diff/1/HACKING.rst
File HACKING.rst (right):

https://codereview.appspot.com/103310043/diff/1/HACKING.rst#newcode106
HACKING.rst:106: Repeat above on ec2.
On 2014/06/11 13:26:46, frankban wrote:
> What do you think about adding a step for verifying remote bundles
with
> simplified names are correctly deployed as well?
> E.g. "juju quickstart bundle:mediawiki/single" or similar?

Does line 103 above not do what you want?

> Also, it would be nice to also live test that the automatically
generated local
> environment works. To do this, we should temporarily remove the
~/.juju and
> launch quickstart, selecting the first option.
> This seems to me particularly important since it is likely the first
thing users
> new to Juju will do when installing quickstart.

Good idea. I'll add it to this branch.

> The above can be done in a separate branch.

https://codereview.appspot.com/103310043/

« Back to merge proposal