Merge lp://qastaging/~bac/launchpad/bug-788685 into lp://qastaging/launchpad
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13510 |
Proposed branch: | lp://qastaging/~bac/launchpad/bug-788685 |
Merge into: | lp://qastaging/launchpad |
Diff against target: |
130 lines (+61/-6) 2 files modified
lib/lp/soyuz/doc/distroseriesqueue-translations.txt (+52/-4) lib/lp/soyuz/model/queue.py (+9/-2) |
To merge this branch: | bzr merge lp://qastaging/~bac/launchpad/bug-788685 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | code | Approve | |
Review via email:
|
Commit message
[r=danilo][bug=788685] Allow translations for components other than 'main' and 'restricted' for Oneiric and onward.
Description of the change
= Summary =
Allow translation packages for distroseries of Oneiric or later to be targeted to components other than 'main' and 'restricted.'
== Proposed fix ==
Bypass the component name test for distoseries >= 11.10.
== Pre-implementation notes ==
Chats with Danilo.
== Implementation details ==
As above.
== Tests ==
Simply extended existing doctest. :(
bin/test -vvt distroseriesque
== Demo and Q/A ==
Hmm.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
I don't see why do you need to import IDistroSeriesSet on line 11 of the diff (in distroseriesque ue-translations .txt). Version check is very nice, nice to learn about that. I don't like the "valid_comp_names" abbreviation: perhaps just use "valid_components" if it's for line length reasons?