Code review comment for lp://qastaging/~bac/launchpad/bug-788685

Revision history for this message
Данило Шеган (danilo) wrote :

I don't see why do you need to import IDistroSeriesSet on line 11 of the diff (in distroseriesqueue-translations.txt). Version check is very nice, nice to learn about that. I don't like the "valid_comp_names" abbreviation: perhaps just use "valid_components" if it's for line length reasons?

review: Approve (code)

« Back to merge proposal