Code review comment for lp://qastaging/~ballogy/bamf-qt/fix-imports-dir-location

Revision history for this message
Balló György (ballogy) wrote :

I found that FindQt4.cmake checks if 'Qt' directory exists in '/usr/lib/qt4/imports/' path. But on Ubuntu, it's probably exists only if one of the following QML plugins installed:
- libqt4-declarative-folderlistmodel
- libqt4-declarative-gestures
- libqt4-declarative-particles
- libqt4-declarative-shaders

What do you think about query qmake directly? It should works even if no QML plugins installed:
_qt4_query_qmake(QT_INSTALL_IMPORTS qt_imports_dir)
set(IMPORT_INSTALL_DIR ${qt_imports_dir}/bamf)

« Back to merge proposal