Code review comment for lp://qastaging/~benoit.pierre/bzrtools/colordiff_when_tty

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Benoit PIERRE wrote:
> OK, so how about a --color option that works like for ls:

Sure. You'll probably want to use
bzrlib.option.RegistryOption.from_kwargs for that.

It seems weird to support color=never, since that's diff, but I can see
it might be useful for overriding color display in a cdiff alias.

> 'auto' being the default mode.

Because we're talking about cdiff, I think the best default is 'always'.
 After all, you're executing a command whose reason for existence is
providing colour output. That's even part of its name.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkhgr8ACgkQ0F+nu1YWqI07rgCfeGCjq9LDB8XEv/64QXmHlyu1
mggAnRSk4iTDW7jKeaZTHvd39IabQfbX
=FZGK
-----END PGP SIGNATURE-----