Code review comment for lp://qastaging/~bilalakhtar/unity/sc-integration-phase2

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

I myself have given up on the AbstractLauncherIcon::Ptr thing after multiple hits and misses. I think it's okay in it's current form, an extra line or two but not too ugly.

Other than that, do you think the code (other than the tests) is good? Could you approve the code then? Of course I'd need to file a UIFe and FFe request before it can get merged, but in the meantime you can approve/reject it.

« Back to merge proposal