Just some drive by comments - I am not sure I am the right guy to review this...
166 + * Copyright (C) 2010 Canonical Ltd
I believe we write 2012 these days ;-)
223 + _aptdaemon_trans->Connect("Finished", sigc::mem_fun(*this, &SoftwareCenterLauncherIcon::OnFinished)); 224 + _aptdaemon_trans->Connect("PropertyChanged", sigc::mem_fun(*this, &SoftwareCenterLauncherIcon::OnPropertyChanged));
Are you sure you mean '*this' and not 'this'?
Generally; I don't like the 'if (!g_strcmp0 (variable, "XYZ"))' construction. Do it like how it's done elsewhere too, with == 0. It improves legibility. Humans doesn't not suck at negations ;-)
« Back to merge proposal
Just some drive by comments - I am not sure I am the right guy to review this...
166 + * Copyright (C) 2010 Canonical Ltd
I believe we write 2012 these days ;-)
223 + _aptdaemon_ trans-> Connect( "Finished" , sigc::mem_ fun(*this, &SoftwareCenter LauncherIcon: :OnFinished) ); trans-> Connect( "PropertyChange d", sigc::mem_ fun(*this, &SoftwareCenter LauncherIcon: :OnPropertyChan ged));
224 + _aptdaemon_
Are you sure you mean '*this' and not 'this'?
Generally; I don't like the 'if (!g_strcmp0 (variable, "XYZ"))' construction. Do it like how it's done elsewhere too, with == 0. It improves legibility. Humans doesn't not suck at negations ;-)