Merge lp://qastaging/~billy-olsen/charm-helpers/pass-params-to-upstart-scripts into lp://qastaging/charm-helpers
Proposed by
Billy Olsen
| Status: | Merged |
|---|---|
| Merged at revision: | 683 |
| Proposed branch: | lp://qastaging/~billy-olsen/charm-helpers/pass-params-to-upstart-scripts |
| Merge into: | lp://qastaging/charm-helpers |
| Diff against target: |
296 lines (+190/-30) 2 files modified
charmhelpers/core/host.py (+158/-30) tests/core/test_host.py (+32/-0) |
| To merge this branch: | bzr merge lp://qastaging/~billy-olsen/charm-helpers/pass-params-to-upstart-scripts |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jorge Niedbalski (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This adds the ability to provide additional arguments to the upstart scripts when attempting to stop, start, restart, reload, etc a service. This is necessary to stop specific service instances in scenarios such as ceph-osd, where it may not always be desirable to be limited to all or none of the service instances at one time.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM, I found a minor issue with one of the tests (https:/
Thanks for your contribution.