Code review comment for lp://qastaging/~billy-olsen/charm-helpers/pass-params-to-upstart-scripts

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

LGTM, I found a minor issue with one of the tests (https://pastebin.canonical.com/178544/), but I fixed it by my own prior to merge the change.

Thanks for your contribution.

review: Approve

« Back to merge proposal