Merge lp://qastaging/~bloodearnest/charm-helpers/ppa-tools into lp://qastaging/charm-helpers
Proposed by
Simon Davy
Status: | Work in progress |
---|---|
Proposed branch: | lp://qastaging/~bloodearnest/charm-helpers/ppa-tools |
Merge into: | lp://qastaging/charm-helpers |
Prerequisite: | lp://qastaging/~michael.nelson/charm-helpers/namespace-relation-data |
Diff against target: |
97 lines (+69/-0) 2 files modified
charmhelpers/core/host.py (+21/-0) tests/core/test_host.py (+48/-0) |
To merge this branch: | bzr merge lp://qastaging/~bloodearnest/charm-helpers/ppa-tools |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Matthew Wedgwood (community) | Needs Fixing | ||
Michael Nelson | Approve | ||
Review via email: mp+175308@code.qastaging.launchpad.net |
Commit message
Added enable_private_ppas and add_apt_key helperss
Description of the change
Added enable_private_ppas and add_apt_key helperss
To post a comment you must log in.
Unmerged revisions
- 48. By Simon Davy
-
Refactor tests to use filesystem, and fix check_call args in add_apt_key
- 47. By Simon Davy
-
typo
- 46. By Simon Davy
-
Added enable_private_ppas and add_apt_key helpers
14:56 <bloodearnest> https:/ /code.launchpad .net/~bloodearn est/charm- helpers/ ppa-tools/ +merge/ 175308 existing_ values( ) charmhelpers
14:56 <bloodearnest> be nice if we could a "shared pipeline" for a fast moving dep branch like that
14:57 <noodles> Yeah
14:57 <noodles> Nice branch!
14:58 <bloodearnest> simple functions
14:58 <noodles> I think mock expectations are used a bit much in charmhelpers... what I've been doing...
14:58 * noodles checks on his own MP
14:58 <bloodearnest> I think a mock filesystem would be better
15:00 <noodles> Yeah - well, I'm not sure if it's what you mean, but you can do that really easily...
15:00 <noodles> If you look at test_updates_
15:00 <noodles> Teh actual code writes a file to /etc/salt/grains
15:01 <noodles> But the test can just mock the path to the grains file with a tmp directory, then the rest of the test is on the actual filesystem.
15:01 <bloodearnest> looking
15:31 <bloodearnest> hmm - not sure how to apply the tmp dir to my test, as the path is a hardcoded one
15:31 <noodles> Oh - you can't make it a module-level path? Yeah, that doesn't work then.
15:32 <bloodearnest> I could, I guess
15:32 <bloodearnest> python needs better whole fs mocking tools
15:32 <noodles> I love mock - so much better than what was available before...
15:35 <bloodearnest> mock is great
15:35 <bloodearnest> I loved how easy it was to mock my new hooks logic with self.mock_
15:35 <noodles> Yeah!