Merge lp://qastaging/~bowmore/unity/fix_icon_workarea_issues into lp://qastaging/unity
Proposed by
Bowmore
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp://qastaging/~bowmore/unity/fix_icon_workarea_issues | ||||
Merge into: | lp://qastaging/unity | ||||
Diff against target: |
28 lines (+2/-2) 2 files modified
plugins/unityshell/src/Launcher.cpp (+1/-1) plugins/unityshell/src/PanelController.cpp (+1/-1) |
||||
To merge this branch: | bzr merge lp://qastaging/~bowmore/unity/fix_icon_workarea_issues | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity Team | Pending | ||
Gord Allott | Pending | ||
Review via email: mp+102174@code.qastaging.launchpad.net |
This proposal has been superseded by a proposal from 2012-07-23.
Description of the change
This change fixes the sporadic compression of the desktop icon workarea in height.
The reason is that the basewindow geometry initially is used for the panel and launcher struts and thus results in a top margin (strut) with the height 300ps instead of 24px that applies to the unity panel, thus losing 276px in workspace height.
This is sporadic (a race condition issue between unity/compiz and nautilus) but more frequent on older computers.
Also see bug #886667
To post a comment you must log in.
Hi, so this code looks fine, However i'm wondering about testing. we have a system called autopilot but i don't think this is a good fit for that unless there is a nice repeatable methodology for triggering this bug.
At the very least there are manual tests that we have written up in the manual-tests/ directory of unity, if you could add a test in there for this bug that follows the same syntax as the rest that would be great