Merge lp://qastaging/~brad-marshall/charms/trusty/nrpe-external-master/fix-rsyncd-conf into lp://qastaging/charms/nrpe-external-master

Proposed by Brad Marshall
Status: Superseded
Proposed branch: lp://qastaging/~brad-marshall/charms/trusty/nrpe-external-master/fix-rsyncd-conf
Merge into: lp://qastaging/charms/nrpe-external-master
Diff against target: 89 lines (+19/-31)
4 files modified
files/rsyncd.conf (+12/-0)
hooks/config-changed (+2/-11)
hooks/install (+5/-11)
templates/rsyncd.conf.tmpl (+0/-9)
To merge this branch: bzr merge lp://qastaging/~brad-marshall/charms/trusty/nrpe-external-master/fix-rsyncd-conf
Reviewer Review Type Date Requested Status
JuanJo Ciarlante (community) Needs Fixing
Review via email: mp+241482@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2014-11-17.

Description of the change

Add support for a /etc/rsync-juju.d file, to allow charms to drop fragments in place. Required for the swift charm to have a working rsync.

To post a comment you must log in.
Revision history for this message
JuanJo Ciarlante (jjo) wrote :

See inline comments, LGTM afterwards.

review: Needs Fixing
36. By Brad Marshall

[bradm] Added timeout to rsyncd.conf

37. By Brad Marshall

[bradm] Removed puppet header from nagios_plugin module

38. By Brad Marshall

[bradm] Added nagios checks for monitoring upstart and sysvinit daemons

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: