76 + if (m_xim_controller) 77 + { 78 + delete m_xim_controller; 79 + }
What about using a smart ptr?
95 + void GraphicsDisplay::XICFocus() 96 + { 97 + m_xim_controller->FocusInXIC(); 98 + } 99 + 100 + void GraphicsDisplay::XICUnFocus() 101 + { 102 + m_xim_controller->FocusOutXIC(); 103 + }
I see that m_xim_controller is not initialized in the ctor. So I think that we should add a null check. Or am I missing something?
+* Copyright 2010-2012 Inalogic® Inc.
I think you don't need 2010 :)
I'll continue the review tomorrow (it's late now...).
« Back to merge proposal
76 + if (m_xim_controller)
77 + {
78 + delete m_xim_controller;
79 + }
What about using a smart ptr?
95 + void GraphicsDisplay ::XICFocus( ) r->FocusInXIC( ); ::XICUnFocus( ) r->FocusOutXIC( );
96 + {
97 + m_xim_controlle
98 + }
99 +
100 + void GraphicsDisplay
101 + {
102 + m_xim_controlle
103 + }
I see that m_xim_controller is not initialized in the ctor. So I think that we should add a null check. Or am I missing something?
+* Copyright 2010-2012 Inalogic® Inc.
I think you don't need 2010 :)
I'll continue the review tomorrow (it's late now...).