Code review comment for lp://qastaging/~brandontschaefer/nux/xim-tests

282 +bool XICClient::HasXIC() const
283 +{
284 + if (xic_ == NULL)
285 + return false;
286 + return true;
287 +}

Mabye return xic_ != null(ptr)?

You're not using nux namespace. Why?

472 + const char *xmodifier;
473 + /* don't do anything if we are using ibus */
474 + xmodifier = getenv("XMODIFIERS");

/*...*/
Maybe const char* xmo... = getenv...

I prefer this style but it's up to you :)

+void XIMController::SetupXIMClientCallback(Display *dpy, XPointer client_data, XPointer call_data)

The * goes with the type.