Code review comment for lp://qastaging/~brandontschaefer/unity/hud-to-dash-fix

Revision history for this message
Tim Penhey (thumper) wrote :

At the end of test_hud_to_dash_has_key_focus you shouldn't need to ensure_hidden on the dash.

If you do because it is a hud test, then change it so the test goes like this:

  self.dash.ensure_visible()
  self.addCleanup(self.dash.ensure_hidden)

That way if the assert fails, the dash is still hidden.

Also, PEP-8 says only one blank line between class methods.

review: Needs Fixing

« Back to merge proposal