Unity

Merge lp://qastaging/~brandontschaefer/unity/ubus-race-overlay-for-panel into lp://qastaging/unity

  1. ubus-race-overlay-for-panel
  2. Merge into trunk
Proposed by Brandon Schaefer
Status: Rejected
Rejected by: Brandon Schaefer
Proposed branch: lp://qastaging/~brandontschaefer/unity/ubus-race-overlay-for-panel
Merge into: lp://qastaging/unity
Diff against target: 93 lines (+20/-23)
4 files modified
dash/DashController.cpp (+4/-9)
launcher/LauncherController.cpp (+1/-1)
manual-tests/Dash.txt (+15/-0)
plugins/unityshell/src/unityshell.cpp (+0/-13)
To merge this branch: bzr merge lp://qastaging/~brandontschaefer/unity/ubus-race-overlay-for-panel
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Needs Information
Tim Penhey (community) Approve
Review via email: mp+122786@code.qastaging.launchpad.net

Commit message

Fixes UBus races condition with Dash opening then closing very fast. As well as the Launcher getting X focus over the Dash.

Description of the change

=== Problem ===
When opening then closing the Dash quickly the Ubus message the panel listens on was sent into a race condition.

=== Fix ===
The problem was from using an Idle while sending OVERLAY SHOWN, which didn't fix the real issue. The real issue is the laucher gets X focus when the Dash is open. This should not happen.

=== Test ===
Manual test

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) :
review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1214/console reported an error when processing this lp:~brandontschaefer/unity/ubus-race-overlay-for-panel branch.
Not merging it.

Revision history for this message
Andrea Azzarone (azzar1) wrote :

78 -
79 - // We do this after the notify to ensure input focus has actually been moved.
80 - if (n == CompWindowNotifyFocusChange)
81 - {
82 - UnityScreen* us = UnityScreen::get(screen);
83 - CompWindow *lw;
84 -
85 - if (us->launcher_controller_->IsOverlayOpen())
86 - {
87 - lw = screen->findWindow(us->launcher_controller_->LauncherWindowId(0));
88 - lw->moveInputFocusTo();
89 - }
90 - }

See this MP [1] to see why we have this code. Do you really want to remove it?

https://code.launchpad.net/~robertcarr/unity/dash-keepfocus/+merge/75739

review: Needs Information
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

That causes the launcher to still focus fromt the Dash. This doesn't causet that problem for me. If I open libre office then open the dash, when libre office finally opens it closes the dash and focuses libre...I mean wouldn't you expect that?

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Getting fixed here:
https://code.launchpad.net/~nick-dedekind/unity/lp923657.dash-dismiss/+merge/123128

Unmerged revisions

2658. By Brandon Schaefer

* forgot to remove comment

2657. By Brandon Schaefer

* Fixed the real issue with the launcher stealing X focus from the dash

2656. By Brandon Schaefer

* Fixes race condition where the panel would recive a OVERLAY HIDDEN before the OVERLAY OPENED

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.