Code review comment for lp://qastaging/~brianaker/drizzle/is-replicated

Revision history for this message
Olaf van der Spek (olafvdspek) wrote :

> template<class T> inline bool is_replicated(const T*& ptr)

Shouldn't pointers be passed by value instead of const&?
The inline keyword probably doesn't matter on template functions.

« Back to merge proposal