Code review comment for lp://qastaging/~cameronnemo/apparmor/gnome-abstraction

Revision history for this message
intrigeri (intrigeri) wrote :

> I'd like to see your added line
> + owner @{HOME}/.config/gtk-3.0/** r,
> merged with the existing
> owner @{HOME}/.config/gtk-2.0/** r,
> which would result in
> owner @{HOME}/.config/gtk-[23].0/** r,

ACK

> If you expect the .0 to change, maybe also [23].[0-9].

I seriously hope that the GTK project will never introduce config directories versioned in this fine grained a way, and I say we can skip this one.

> BTW: I noticed
> owner @{HOME}/.config/gtk-2.0/gtkfilechooser.ini* rw,
> Is writing that file also needed with gtk 3? If yes, please also change it to
> [23].0 or [23].[0-9].

This file doesn't exist on a modern desktop system that uses GTK+ 3.x intensively, so I don't think it's needed.

« Back to merge proposal