UTAH

Merge lp://qastaging/~canonical-platform-qa/utah/vm-wait-for-shutdown into lp://qastaging/utah

  1. vm-wait-for-shutdown
  2. Merge into dev
Proposed by Max Brustkern
Status: Merged
Merged at revision: 1075
Proposed branch: lp://qastaging/~canonical-platform-qa/utah/vm-wait-for-shutdown
Merge into: lp://qastaging/utah
Diff against target: 54 lines (+16/-13)
1 file modified
utah/provisioning/vm.py (+16/-13)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/utah/vm-wait-for-shutdown
Reviewer Review Type Date Requested Status
Christopher Lee (community) Approve
Scott Moser (community) Approve
Paul Larson Approve
Review via email: mp+285660@code.qastaging.launchpad.net

Description of the change

This branch removes the rsyslog checks during vm provisioning. Rsyslog fails on a regular basis in production, so the install check will cause the job to fail, and the boot check will cause the job to needlessly wait 10 minutes.

To post a comment you must log in.
lp://qastaging/~canonical-platform-qa/utah/vm-wait-for-shutdown updated
1086. By Max Brustkern

Restore original docstring to match original functionality

1087. By Max Brustkern

Added delta to logging

Revision history for this message
Paul Larson (pwlars) wrote :

+1 on removing rsyslog if it works, but without vm.destroy()/vm.undefine() doesn't it leak VMs? iirc, those used to pile up pretty quickly, and someone (probably you) fixed it by making sure this got properly cleaned up.

review: Needs Information
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Good point, I forgot why we did that. I'll put it back in with a comment.

lp://qastaging/~canonical-platform-qa/utah/vm-wait-for-shutdown updated
1088. By Max Brustkern

Don't leak VMs on exceptions

Revision history for this message
Paul Larson (pwlars) wrote :

+1 :)

review: Approve
Revision history for this message
Christopher Lee (veebers) wrote :

Have a query and a suggestion. If it doesn't loop indefinitely and my suggestion is out of scope this is a LGTM from me.

review: Needs Information
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Responses to diff comments!

Revision history for this message
Scott Moser (smoser) wrote :

this looks good to me.
thanks for adding the log info of how long it took.

Revision history for this message
Scott Moser (smoser) :
review: Approve
Revision history for this message
Christopher Lee (veebers) wrote :

Sweet, happy that it won't loop forever.
Re; the context manager, that's out of scope for this MP. We can work on that in the future if needed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches