Code review comment for lp://qastaging/~chad.smith/charms/trusty/glance-simplestreams-sync/handle-connectionerror

Revision history for this message
Данило Шеган (danilo) wrote :

Looks good, thanks for the fix: it's been tested on a deployed cloud. (I've got a task on the board to invert the logic in the script to only remove the "cronpoll" on actual success, but didn't get to it for 16.05: it would avoid us having to deal with every potential exception one-by-one)

Once merged, a simple "charm push PATH-TO-CHECKOUT-OF-landscape 'cs:~landscape-charmers/trusty/glance-simplestreams-sync'" followed by charm publish on the likely resulting -7 should be sufficient (permissions are already set up on it).

review: Approve

« Back to merge proposal