Thanks for starting this.
I'd suggest also adding in the add_patch() which is repeated in many of the base classes in the unittests. It's fine if we punt that to a second MP after this lands as well.
Overall looks fine, couple of questions in line.
« Back to merge proposal
Thanks for starting this.
I'd suggest also adding in the add_patch() which is repeated in many of the base classes in the unittests. It's fine if we punt that to a second MP after this lands as well.
Overall looks fine, couple of questions in line.