Merge lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter into lp://qastaging/~landscape/landscape-client/trunk
Proposed by
Chad Smith
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Chad Smith | ||||
Approved revision: | 885 | ||||
Merged at revision: | 896 | ||||
Proposed branch: | lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter | ||||
Merge into: | lp://qastaging/~landscape/landscape-client/trunk | ||||
Diff against target: |
214 lines (+37/-54) 1 file modified
landscape/package/tests/test_reporter.py (+37/-54) |
||||
To merge this branch: | bzr merge lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
🤖 Landscape Builder | test results | Approve | |
Chris Glass (community) | Approve | ||
Adam Collard (community) | Approve | ||
Review via email: mp+297647@code.qastaging.launchpad.net |
Commit message
Phase 1, replace basic logging mocker w/ mock patches.
This file has significant mocker use. It is separated into parts to aid reviews.
Description of the change
Phase 1, replace basic logging mocker w/ mock patches.
This file has significant mocker use. It is separated into parts to aid reviews.
Testing instructions:
trial landscape.
To post a comment you must log in.
some nits, +1