Code review comment for lp://qastaging/~charlesk/indicator-bluetooth/upstart-job

On Fri, Dec 06, 2013 at 10:21:17PM +0000, Iain Lane wrote:
> On Fri, Dec 06, 2013 at 10:15:35PM -0000, Ted Gould wrote:
> > On Fri, 2013-12-06 at 17:44 +0000, Iain Lane wrote:
> >
> > > Instead of NotShowIn, you should ship a desktop file with Hidden=true in /usr/share/upstart/xdg/autostart/ (this directory is prepended to XDG_CONFIG_DIRS under upstart user sessions). This will cause it to not start via XDG autostart exactly when user sessions are in use, which is probably what you really want. Having Unity in there smells a bit.
> >
> >
> > The problem is the opposite. We want it to start in non-Upstart user
> > sessions and use the Upstart job in Upstart user sessions.
>
> That's what I said.

To be clear, you ship both desktop files. See gnome-settings-daemon for
an example.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]