Merge lp://qastaging/~charlesk/indicator-datetime/lp-1295799-date-menuitem-should-open-calendar into lp://qastaging/indicator-datetime/14.04
Proposed by
Charles Kerr
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ted Gould | ||||
Approved revision: | 329 | ||||
Merged at revision: | 332 | ||||
Proposed branch: | lp://qastaging/~charlesk/indicator-datetime/lp-1295799-date-menuitem-should-open-calendar | ||||
Merge into: | lp://qastaging/indicator-datetime/14.04 | ||||
Diff against target: |
1162 lines (+537/-305) 11 files modified
README (+16/-8) include/datetime/actions-live.h (+11/-8) include/datetime/actions.h (+13/-7) src/actions-live.cpp (+38/-25) src/actions.cpp (+81/-61) src/menu.cpp (+32/-24) tests/actions-mock.h (+46/-23) tests/test-actions.cpp (+192/-104) tests/test-exporter.cpp (+8/-5) tests/test-live-actions.cpp (+80/-29) tests/test-menus.cpp (+20/-11) |
||||
To merge this branch: | bzr merge lp://qastaging/~charlesk/indicator-datetime/lp-1295799-date-menuitem-should-open-calendar | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
Add support for opening the calendar app on the phone via the date menuitem.
Description of the change
Add support for opening the calendar app on the phone via the date menuitem.
To post a comment you must log in.
> * Ensure the project compiles and the test suite executes without error
Done on desktop + nexus phone.
> * Ensure that non-obvious code has comments explaining it
No new non-obvious code. The per-profile actions are actually more readable now.
> * If the change works on specific profiles, please include those in the merge description.
Changes phone behavior s.t. clicking on the date menuitem pops up the calendar app.