Code review comment for lp://qastaging/~chemikadze/nova/contrib-extention-networks

Revision history for this message
Matt Dietz (cerberus) wrote :

Thanks for the fixes, but noticed something else

In the test methods where you use the global keyword, you actually don't need it. Python is a little opaque on how it handles scoping, but in the methods where you don't actually reassign fake_nets, you don't need global.

See http://paste.openstack.org/show/2487/

300 + global fake_nets
301 + fake_nets = init_fake_nets()

You *would* need it here, because you're assigning it.

« Back to merge proposal