Code review comment for lp://qastaging/~christian-w/lightdm/qt-binding-keyboard-layouts

Revision history for this message
David Edmundson (david.edmundson) wrote :

I think it would be a good idea for you to address my first two review comments.
Ignore the bit after "The other approach", the bit beforehand about casting will prevent a potential awkward crash in the future.

But feel free to approve it if you think otherwise.

« Back to merge proposal