Code review comment for lp://qastaging/~cimi/overlay-scrollbar/fix-754927

Revision history for this message
David Barth (dbarth) wrote :

The changes are ok here, but I think there's more to the bug.

1. the user_data may contain a dead pointer, so even getting access to ->priv may fail
2. in order to avoid dead pointers still reaching the callback, shouldn't you disconnect the animation signal as well on dispose?

review: Needs Information

« Back to merge proposal