Code review comment for lp://qastaging/~cimi/unity8/card-shadows-uitk1.1

Revision history for this message
Andrea Cimitan (cimi) wrote :

> Why do we need the export_qmlfiles ?

this export the png files in the installation directory

> Can maybe we make
>
> readonly property var artShapeStyle: cardTool.artShapeSize === Qt.size(units.gu(8), units.gu(7.5)) ? "shadow" : "inset";
>
> a bit less hackish if we pass the scope name or something from above?

This would also require to copy/paste the other logic in place, like "if (scope && scope.id === "clickscope" && (categoryId === "predefined" || categoryId === "local"))"

« Back to merge proposal