Session Menu

Merge lp://qastaging/~cjcurran/indicator-session/migrate-to-new-apt-api into lp://qastaging/indicator-session/0.4

migrate-to-new-apt-api
Merge into trunk.0.4

Proposed by Conor Curran on 2012-02-08

Status:

Merged

Merged at revision:

237

Proposed branch:

lp://qastaging/~cjcurran/indicator-session/migrate-to-new-apt-api

Merge into:

lp://qastaging/indicator-session/0.4

Diff against target:

1020 lines (+190/-715)

7 files modified

configure.ac (+4/-2)
src/Makefile.am (+1/-3)
src/apt-transaction.c (+0/-263)
src/apt-transaction.h (+0/-49)
src/apt-watcher.c (+183/-397)
src/apt-watcher.h (+0/-1)
src/user-widget.c (+2/-0)

To merge this branch:

bzr merge lp://qastaging/~cjcurran/indicator-session/migrate-to-new-apt-api

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ted Gould (community)		2012-02-08	Approve on 2012-02-08
Review via email: mp+92088@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-02-08.

Description of the change

Brings correctness to the apt menuitem.

Revision history for this message

Ted Gould (ted) wrote on 2012-02-08:

Some little things, nothing major:

* pk_client_generic_finish, should really use the error parameter to get a cleaner error
* Should probably just drop this code:
569 + else if (g_strcmp0(signal_name, "TransactionListChanged") == 0) {
570 + GVariant *value = g_variant_get_child_value (parameters, 0);
571 + g_variant_unref (value);
572 +
573 + }
* I think we can drop apt_watcher_on_name_appeared and apt_watcher_on_name_vanished as well
* This should probably be in the C file instead of the H
+#include "dbus-shared-names.h"