Code review comment for lp://qastaging/~cjcurran/indicator-session/migrate-to-new-apt-api

Revision history for this message
Ted Gould (ted) wrote :

Some little things, nothing major:

* pk_client_generic_finish, should really use the error parameter to get a cleaner error
* Should probably just drop this code:
569 + else if (g_strcmp0(signal_name, "TransactionListChanged") == 0) {
570 + GVariant *value = g_variant_get_child_value (parameters, 0);
571 + g_variant_unref (value);
572 +
573 + }
* I think we can drop apt_watcher_on_name_appeared and apt_watcher_on_name_vanished as well
* This should probably be in the C file instead of the H
+#include "dbus-shared-names.h"

review: Approve

« Back to merge proposal