Merge lp://qastaging/~cjwatson/snapcraft/tidy-noninteractive-logging into lp://qastaging/~snappy-dev/snapcraft/core
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Sergio Schvezov | ||||
Approved revision: | 219 | ||||
Merged at revision: | 220 | ||||
Proposed branch: | lp://qastaging/~cjwatson/snapcraft/tidy-noninteractive-logging | ||||
Merge into: | lp://qastaging/~snappy-dev/snapcraft/core | ||||
Diff against target: |
121 lines (+30/-8) 3 files modified
snapcraft/log.py (+12/-2) snapcraft/repo.py (+14/-3) snapcraft/tests/test_log.py (+4/-3) |
||||
To merge this branch: | bzr merge lp://qastaging/~cjwatson/snapcraft/tidy-noninteractive-logging | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Schvezov | Approve | ||
Michael Vogt (community) | Approve | ||
Review via email:
|
Commit message
Apply better logging and progress behaviour if stdout is not a tty.
Description of the change
Launchpad snap builds have very noisy logs. For example:
https:/
This applies better logging and progress behaviour in the case where stdout is not a tty: we get rid of the ANSI escapes in snapcraft's own logging output, and we suppress the "pulse" step in apt's progress output.
I also arranged to use the system's apt/GPG configuration. This was prompted by apt missing a newline in its stderr output in that case which made the output look weird, but it seems correct to do this anyway rather than doing insecure downloads.
thank you Colin!