Code review comment for lp://qastaging/~cmiller/desktopcouch/add-running-context-as-parameter

Revision history for this message
Chad Miller (cmiller) wrote :

> Also in __init__.py a default argument is used:
>
> local_files.DEFAULT_CONTEXT
>
> but local_files is never imported. Is this a kind of magic that I forgot
> about, or are no errors triggered since the tests always pass an argument? In
> that case, we should add a test that does not pass a kw argument (but does not
> manipulate anything in the context, since that was what we set out to prevent)

It's the __init__ for this module. Other parts of this module are available. We don't need to import ourselves, e.g., and access desktopcouch.local_files .

Try it. In __init__.py, add "print local_files" and start a python shell and "import desktopcouch" .

« Back to merge proposal