Code review comment for lp://qastaging/~cmiller/desktopcouch/config-file-clean-up

Revision history for this message
Nicola Larosa (teknico) wrote :

Tests pass, nice code. Thanks for taking code out of exec scripts and into lib files: even more code can be moved, though. ;-)

I don't like static methods, why not just using functions outside classes? Especially for something like "_make_random_string": does it really need to be private anyway? The underscore in _Configuration also seems weird, never seen a private class at module level before. What's the use?

review: Approve

« Back to merge proposal