Code review comment for lp://qastaging/~coalwater/lernid/fix-925702

Revision history for this message
Mohammad AbuShady (coalwater) wrote :

When i think about it i'm not sure if these changes broke the other checks or not

                if self._nick in text and sender != self._nick:
                    self._buffer.insert_with_tags_by_name(iend, text, 'highlight')
                elif self._on_faculty(sender):
                    self._buffer.insert_with_tags_by_name(iend, text, 'highlight')
                elif sender.lower() in self._classbotnames:
                    self._buffer.insert_with_tags_by_name(iend, text, 'italicize')

i think i should test them first

« Back to merge proposal