Code review comment for lp://qastaging/~compiz-team/compiz/compiz.fix_1016364
Revision history for this message
| Sam Spilsbury (smspillaz) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> Sorry, still broken.
>
> Using trunk I get nice bilinear-filtered mipmaps. Using this branch, I get no
> mipmaps (and hence no bilinear filtering).
You actually still get bilinear filtering (or at least should ... I can double check). Note that you don't actually need mipmapping support to get bilinear filtering, you only need it for /trilinear/ filtering (eg GL_LINEAR_
Like I just explained, there's a driver bug at work here (spoke to RAOF about it yesterday). That leaves us with three options, and I'd like some guidance as to which one to take.
a) Fix mesa to correctly report whether it supports mipmapping on glx pixmap configs (should take me 2-3 days)
b) Add a workaround to force mipmapping even if the driver doesn't say it supports it
c) "revert" the code that detects whether mipmapping is supported correctly and truly break other drivers where mipmapping really isn't supported.
c)