Merge lp://qastaging/~compiz-team/compiz/compiz.fix_1037142 into lp://qastaging/compiz/0.9.8

Proposed by Sam Spilsbury
Status: Superseded
Proposed branch: lp://qastaging/~compiz-team/compiz/compiz.fix_1037142
Merge into: lp://qastaging/compiz/0.9.8
Prerequisite: lp://qastaging/~compiz-team/compiz/compiz.fix_1053820
Diff against target: 317 lines (+111/-39)
6 files modified
plugins/expo/src/expo.cpp (+0/-26)
plugins/grid/src/grabhandler/include/grabhandler.h (+38/-2)
plugins/grid/src/grabhandler/src/grabhandler.cpp (+7/-2)
plugins/grid/src/grabhandler/tests/test-grid-grab-handler.cpp (+58/-5)
plugins/grid/src/grid.cpp (+5/-1)
src/event.cpp (+3/-3)
To merge this branch: bzr merge lp://qastaging/~compiz-team/compiz/compiz.fix_1037142
Reviewer Review Type Date Requested Status
Daniel van Vugt Needs Resubmitting
jenkins (community) continuous-integration Needs Fixing
Review via email: mp+125837@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2012-09-24.

Commit message

Don't trigger the grid plugin during expo mode. Remove redundant checks in Expo which could cause this to happen.

Description of the change

Don't trigger the grid plugin during expo mode. Remove redundant checks in Expo which could cause this to happen.

Tests added for the first part. The second part is better tested by the branch this one depends on.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

CI appears to be 404ing

Revision history for this message
Martin Mrazik (mrazik) wrote :

> CI appears to be 404ing

Sorry. That is a but that needs to be workarounded every now and then. Should work now. This is the relevant error:

patching file plugins/expo/src/windows_on_viewport/src/windows-on-viewport.cpp
patching file plugins/expo/src/windows_on_viewport/tests/CMakeLists.txt
patching file plugins/expo/src/windows_on_viewport/tests/test-windows-on-viewport.cpp
patching file plugins/expo/src/client-list-generator.h
patching file plugins/expo/src/viewport-member-window.h
Patch 100_expo_layout.patch does not apply (enforce with -f)
dh_quilt_patch: quilt --quiltrc /dev/null push -a || test $? = 2 returned exit code 1
make[1]: *** [override_dh_quilt_patch] Error 1
make[1]: Leaving directory `/tmp/buildd/compiz-0.9.8.2+bzr3377'
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Resubmit per the prereq branch.

review: Needs Resubmitting

Unmerged revisions

3391. By Sam Spilsbury

Don't trigger the grid grab handler when expo is active, don't trigger
inactive actions and remove redundant checks for the root window match
because we don't support the multi-screen case and haven't since
0.9.0

3390. By Sam Spilsbury

Don't trigger actions unless they're actually added

3389. By Sam Spilsbury

Restrict access of private data in CompAction to a separate nonmember
function, add a test for its usage

3388. By Sam Spilsbury

Refactored out the rest of that function and tested it

3387. By Sam Spilsbury

Reworked the way actions are set up to be more in line with how
compiz expects it. Now the tests pass

3386. By Sam Spilsbury

Split out some of triggerButtonPressBindings and get it under test, currently
some tests fail due to incorrect behaviour in CompOption::set, a failing
test added to show this

3385. By Sam Spilsbury

Use boost::bind

3384. By Sam Spilsbury

Move the check for the button action modifiers & event state to a separate
function

3383. By Sam Spilsbury

Refactored out the edge detection code from triggerButtonPressBindings
into a separate util function under test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches